-
Notifications
You must be signed in to change notification settings - Fork 299
Simplify CODEOWNERS #2864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Simplify CODEOWNERS #2864
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR simplifies maintenance of the CODEOWNERS file by replacing individual user handles with a GitHub team for most code ownership entries. The primary purpose is to streamline code review assignments and reduce the need to manually update individual maintainer lists.
- Replaces individual maintainer handles with
@Azure/azure-sdk-rust-dev
team across most entries - Maintains specific individual owners for certain specialized areas (e.g., storage, identity)
- Preserves existing team-based ownership for engineering systems
@RickWinter, looks like the team alias isn't valid. Are all the org memberships public? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The group has to be valid. Work with EngSys to define it.
It is valid. I believe it might just be replication delay. |
@@ -68,12 +68,12 @@ | |||
# ServiceOwner: @Azure/azure-sdk-write-keyvault | |||
# ServiceLabel: %KeyVault | |||
# PRLabel: %KeyVault | |||
/sdk/keyvault/ @Azure/azure-sdk-write-keyvault @heaths | |||
/sdk/keyvault/ @Azure/azure-sdk-write-keyvault @Azure/azure-sdk-rust-dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is overkill. I wanted to stay on here because I have traditionally owned it and using it as a sort of test for core changes.
No description provided.